feat(cron): add executions prune/clear CLI commands (#59909) - #59921
Closed
webtecnica wants to merge 1 commit into
Closed
webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
Adds `hermes cron executions prune --older-than 7d` and `hermes cron executions clear --job-id <id> | --all` for managing cron job execution output files. Closes NousResearch#59909
Contributor
Author
|
@teknium1 Ready for review. New CLI commands |
Collaborator
|
Thanks for the cleanup proposal. This is an automated hermes-sweeper review; current
Because the current implementation already provides retention for output files and a CLI purge for the desktop-visible run history, this PR is redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cron job execution history accumulates indefinitely under
~/.hermes/cron/output/<job_id>/, with no way to clean it. This adds CLI commands to manage it.Changes
hermes cron executions prune --older-than 7dDeletes execution output files older than N days/hours/minutes/seconds. Useful for automated cleanup (can be run as a cron job itself).
hermes cron executions clear --job-id <id>/hermes cron executions clear --allClears execution history for a specific job or all jobs.
Implementation
hermes_cli/subcommands/cron.py— newexecutionssubcommand withpruneandclearsub-parsershermes_cli/cron.py—_cron_executions()function reading from~/.hermes/cron/output/--older-thanformat, and non-existent job IDsFiles Changed
hermes_cli/subcommands/cron.pyhermes_cli/cron.pyCloses #59909