fix(hindsight): surface retain timeouts clearly

[ai-ag2026]

Make Hindsight memory-provider retain timeouts explicit instead of failing silently, so a slow/unreachable retain surfaces a clear signal rather than a swallowed error.

Testing

pytest tests/plugins/memory/test_hindsight_provider.py → 117 passed, on current main.

[teknium1]

Thanks for addressing an actual visibility gap. On current main, _run_sync propagates the blank-message timeout from future.result() (plugins/memory/hindsight/__init__.py:274-281), and hindsight_retain exposes str(e) directly (plugins/memory/hindsight/__init__.py:1725-1727).

Problems

• The added production call uses operation_name="hindsight client operation" (plugins/memory/hindsight/__init__.py:1157), so retain calls do not produce the retain-specific wording used by the new test. The test supplies "hindsight retain" directly to the private bridge instead (tests/plugins/memory/test_hindsight_provider.py, added test in PR commit 61aa2ad3ce62).
• The regression test does not exercise the public retain-tool response or the queued auto-retain path, whose failures are logged by the writer (plugins/memory/hindsight/__init__.py:1124-1126).

Suggested changes

• Thread a retain-specific operation name through _run_hindsight_operation from each aretain_batch caller.
• Assert the actual hindsight_retain JSON error contains the timeout and duration; cover queued retain logging if that path is in scope.

This is an automated hermes-sweeper review.

[ai-ag2026]

@teknium1 Current head 5f0deff0a0c4a97477377b056c8e1bc71f658a5a addresses the timeout-label blocker across all retain paths with public-path regression coverage. Full CI is green (23 successful checks); ready for re-review.

[GottZ]

This was generated by AI during triage.

Summary

Two PRs address the Issue's timeout-visibility cause, while #57612 also bundles separate compression and environment-snapshot hardening. #59842 carries the Hindsight fix further than #57612 by propagating retain-specific operation names through public retain, auto-retain, and flush-on-switch paths, with public-path regression coverage.

Related pull requests

• Hardening fixes for compression, Hindsight, and env snapshots #57612 [closed] related — (+191/-30) — n/a: Bundles three hardening areas: non-object tool arguments, Hindsight timeout reporting, and secret-filtered atomic environment snapshots. It remains relevant as a closed consolidation reference, but its Hindsight slice is superseded by the more complete fix(hindsight): surface retain timeouts clearly #59842 implementation; the discussion also identifies the compression slice as superseded on main and the environment work as maintained in fix: harden subprocess env handling (scrub secrets, isolate browser sessions) #59840. The automated maintainer-bot verdict was keep_open with high salvageability, but the later consolidation discussion records that no remaining unique hunk needs porting and identifies fix: harden subprocess env handling (scrub secrets, isolate browser sessions) #59840/fix(hindsight): surface retain timeouts clearly #59842 as the maintained destinations.
• fix(hindsight): surface retain timeouts clearly #59842 related — (+61/-14) — n/a: Makes Hindsight timeouts cancellable and explicit, threads "hindsight retain" through public retain, auto-retain, and flush-on-switch paths, and tests the public retain response plus timeout handling. The contributor review is COMMENTED with a keep_open verdict and requests confirmation of those paths; the visible diff contains those requested production call-site and public-path test changes, so the next step is contributor re-review rather than treating the PR as merge-ready.

Duplicates

#57612 and #59842 overlap on the core Hindsight timeout-handling change, but they are not fully identical: #59842 adds retain-specific operation-name propagation through public retain, auto-retain, and flush-on-switch paths. The Hindsight portion of closed #57612 can therefore be treated as superseded by #59842; its compression and environment portions are separate slices.

Suggested consolidation

Keep #59842 open with a salvage path: request re-review from the contributor who posted the COMMENTED keep_open review, explicitly confirming the visible diff's public retain, auto-retain, and flush-on-switch coverage. Keep #57612's existing consolidation closure in place rather than issuing a new close action; this follows the discussion's maintained-destination evidence despite the earlier automated keep_open verdict, and its overlapping Hindsight slice can be considered superseded by #59842.

Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 27 kB of PR diffs, 2 kB of issue/PR text, 3 kB of discussion (3 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.