feat(desktop): add toggle to hide unconfigured providers in model picker - #59744
Closed
brian717 wants to merge 1 commit into
Closed
feat(desktop): add toggle to hide unconfigured providers in model picker#59744brian717 wants to merge 1 commit into
brian717 wants to merge 1 commit into
Conversation
The model picker lists every provider from the catalog, including canonical rows the user has no credentials for. Add an opt-in "Hide Unconfigured Providers" toggle to the picker footer that filters out providers whose `authenticated` flag is explicitly false, so users who only configured a few providers aren't scrolling past the rest. The setting persists per the existing model-visibility storage pattern and defaults off, leaving current behavior unchanged. The active provider is always kept visible so the current model can never disappear. Closes NousResearch#59483
19 tasks
Contributor
|
Thanks for the focused Desktop implementation. This is an automated hermes-sweeper review.
Closing as implemented on main; the current default behavior is stronger than the proposed opt-in toggle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in "Hide Unconfigured Providers" toggle to the Desktop model-picker footer (next to Edit Models). When enabled, the picker hides providers the user has no usable credentials for, so someone who only configured a couple of providers isn't scrolling past the entire catalog.
Resolves #59483.
Why
The picker lists every provider from the catalog, including canonical rows surfaced with a setup affordance that the user hasn't set up. The issue reporter (uses only DeepSeek) has to scroll past Anthropic, OpenAI, Google, OpenRouter, etc. every time.
The data needed already exists on the frontend;
ModelOptionProvider.authenticatedis "True when the provider has usable credentials", so no backend change is required.Changes
store/model-visibility.ts: new persisted$hideUnconfiguredProvidersatom + setter (reuses the existingstoredBoolean/persistBooleanstorage pattern), and a purefilterConfiguredProviders(providers, hide, currentProviderSlug)helper.app/shell/model-menu-panel.tsx: reads the store, filterspickerProviders, and renders the toggle with a check mark when active.hideUnconfiguredstring added toen.ts,zh.ts, andtypes.ts.store/model-visibility.test.ts: 4 new unit tests for the filter helper.Design notes
authenticated === falseis filtered; a missing flag is treated as configured (safe default for user/custom providers).Testing
vitest runon the affected suites: 26 passed (incl. 4 new).tsc --noEmit: clean.eslinton all changed files: clean.Renderer typecheck/tests only; full desktop build (
tsc -b+ vite) not run.