fix(agent): skip compression when latest summary leaves no messages to summarize - #59737
fix(agent): skip compression when latest summary leaves no messages to summarize#59737ms-alan wants to merge 1 commit into
Conversation
… to summarize Closes NousResearch#59496
Duplicate of #59526 — both add the identical |
|
Thanks for the focused compression no-op guard. Current Problems
Suggested changes
This is an automated hermes-sweeper review. |
|
Thanks @ms-alan — you independently identified the empty post-handoff window bug (and the correct early-return site). The fix landed via salvage PR #70251, built on #59526 which was the 7-hours-earlier duplicate carrying a regression test — per our earliest-submitter convention that PR was the vehicle, but your identification is credited in the salvage PR body. Closing as landed on main. |
Closes #59496
When a persisted handoff summary sits in the protected head after resume, the compression window recomputes
turns_to_summarizeas an empty slice. Previously Hermes would call_generate_summary([]), which triggers a noisy 'Context compression aborted' warning with no actual data loss.This adds an early-return guard immediately after the slice is recomputed, mirroring the earlier
compress_start >= compress_endno-op path and avoiding an unnecessary context engine request.