Skip to content

fix(file): set success=false when file write blocked by staleness/partial-read guard (#59600) #59685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webtecnica wants to merge 1 commit into from
Closed

fix(file): set success=false when file write blocked by staleness/partial-read guard (#59600) #59685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/file_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,6 +1675,7 @@ def write_file_tool(path: str, content: str, task_id: str = "default",
result_dict = result.to_dict()
if stale_warning:
result_dict["_warning"] = stale_warning
result_dict["success"] = False
if not result_dict.get("error"):
_mark_verification_stale(task_id, [path], session_id=session_id)
_update_read_timestamp(path, task_id)
Expand All @@ -1697,6 +1698,7 @@ def write_file_tool(path: str, content: str, task_id: str = "default",
effective_warning = cross_warning or stale_warning or cwd_warning
if effective_warning:
result_dict["_warning"] = effective_warning
result_dict["success"] = False
# Always report the ABSOLUTE path actually written, so a wrong-cwd
# mismatch is visible in the response instead of silently routing
# the edit to the wrong checkout.
Expand Down
Loading