Skip to content

feat(gateway): add watcher notification modes - #593

Closed
PeterFile wants to merge 1 commit into
NousResearch:mainfrom
PeterFile:feat/gateway-background-process-notifications
Closed

feat(gateway): add watcher notification modes#593
PeterFile wants to merge 1 commit into
NousResearch:mainfrom
PeterFile:feat/gateway-background-process-notifications

Conversation

@PeterFile

@PeterFile PeterFile commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

What changed

  • add display.background_process_notifications for gateway watcher updates
  • support off, result, error, and all modes
  • add unit tests for watcher delivery behavior
  • document the new config in cli-config.yaml.example and AGENTS.md

Why

  • background process stdout in Telegram/Discord can be too noisy for long-running coding tasks
  • this preserves the current behavior by default while allowing quieter modes

How to test

  • set display.background_process_notifications to each mode
  • run a background terminal task with check_interval
  • verify:
    • off: no watcher messages
    • result: only final message
    • error: only final non-zero exit message
    • all: running updates plus final message
  • run:
    • pytest -q tests/gateway/test_background_process_notifications.py tests/gateway/test_config.py

Platforms tested

  • macOS local test environment

Closes #592

Add configurable background process watcher notifications for gateway chats.\n\nSupport all, result, error, and off modes while preserving the current default behavior. Add unit tests and document the new config in the local contributor guidance and config example.\n\nRefs NousResearch#592
teknium1 added a commit that referenced this pull request Mar 10, 2026
Add display.background_process_notifications config option to control
how chatty the gateway process watcher is when using
terminal(background=true, check_interval=...) from messaging platforms.

Modes:
  - all:    running-output updates + final message (default, current behavior)
  - result: only the final completion message
  - error:  only the final message when exit code != 0
  - off:    no watcher messages at all

Also supports HERMES_BACKGROUND_NOTIFICATIONS env var override.

Includes 12 tests (5 config loading + 7 watcher behavior).

Inspired by @PeterFile's PR #593. Closes #592.
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the idea @PeterFile — this is a genuinely useful feature. Your branch was 253 commits behind main with merge conflicts in 3/4 files, so we reimplemented it on the current codebase in PR #840, crediting you in the commit message.

The implementation follows the same mode design you proposed (off, result, error, all), adapted to the current _run_process_watcher code. Appreciate the contribution!

@teknium1 teknium1 closed this Mar 10, 2026
@PeterFile

Copy link
Copy Markdown
Contributor Author

Thanks for the idea @PeterFile — this is a genuinely useful feature. Your branch was 253 commits behind main with merge conflicts in 3/4 files, so we reimplemented it on the current codebase in PR #840, crediting you in the commit message.

The implementation follows the same mode design you proposed (off, result, error, all), adapted to the current _run_process_watcher code. Appreciate the contribution!

Thanks for handling the conflicts and the credit! Glad to see the feature is useful.

teknium1 added a commit that referenced this pull request Mar 10, 2026
…ne spam

- feat(gateway): configurable background_process_notifications (off/result/error/all)
- fix(display): rate-limit spinner flushes to prevent line spam under patch_stdout

Background notifications inspired by @PeterFile (PR #593).
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
Add display.background_process_notifications config option to control
how chatty the gateway process watcher is when using
terminal(background=true, check_interval=...) from messaging platforms.

Modes:
  - all:    running-output updates + final message (default, current behavior)
  - result: only the final completion message
  - error:  only the final message when exit code != 0
  - off:    no watcher messages at all

Also supports HERMES_BACKGROUND_NOTIFICATIONS env var override.

Includes 12 tests (5 config loading + 7 watcher behavior).

Inspired by @PeterFile's PR NousResearch#593. Closes NousResearch#592.
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…x spinner line spam

- feat(gateway): configurable background_process_notifications (off/result/error/all)
- fix(display): rate-limit spinner flushes to prevent line spam under patch_stdout

Background notifications inspired by @PeterFile (PR NousResearch#593).
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Add display.background_process_notifications config option to control
how chatty the gateway process watcher is when using
terminal(background=true, check_interval=...) from messaging platforms.

Modes:
  - all:    running-output updates + final message (default, current behavior)
  - result: only the final completion message
  - error:  only the final message when exit code != 0
  - off:    no watcher messages at all

Also supports HERMES_BACKGROUND_NOTIFICATIONS env var override.

Includes 12 tests (5 config loading + 7 watcher behavior).

Inspired by @PeterFile's PR NousResearch#593. Closes NousResearch#592.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…x spinner line spam

- feat(gateway): configurable background_process_notifications (off/result/error/all)
- fix(display): rate-limit spinner flushes to prevent line spam under patch_stdout

Background notifications inspired by @PeterFile (PR NousResearch#593).
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
Add display.background_process_notifications config option to control
how chatty the gateway process watcher is when using
terminal(background=true, check_interval=...) from messaging platforms.

Modes:
  - all:    running-output updates + final message (default, current behavior)
  - result: only the final completion message
  - error:  only the final message when exit code != 0
  - off:    no watcher messages at all

Also supports HERMES_BACKGROUND_NOTIFICATIONS env var override.

Includes 12 tests (5 config loading + 7 watcher behavior).

Inspired by @PeterFile's PR NousResearch#593. Closes NousResearch#592.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…x spinner line spam

- feat(gateway): configurable background_process_notifications (off/result/error/all)
- fix(display): rate-limit spinner flushes to prevent line spam under patch_stdout

Background notifications inspired by @PeterFile (PR NousResearch#593).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: configurable gateway background process watcher notifications

2 participants