fix(context): add return_exceptions to asyncio.gather in reference expansion - #59258
Closed
x7peeps wants to merge 4 commits into
Closed
fix(context): add return_exceptions to asyncio.gather in reference expansion#59258x7peeps wants to merge 4 commits into
x7peeps wants to merge 4 commits into
Conversation
Contributor
Author
|
Closing as superseded by #59954 (consolidated context reference expansion fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add to in so that a single failed reference expansion does not crash the entire concurrent expansion of all other references.
Problem
calls without when expanding multiple references (file, folder, url, etc.) concurrently. If one reference fails (e.g. a URL fetch times out or a file is unreadable), the exception propagates and aborts all other reference expansions in flight. A message like would lose the expansion too.
Fix
Testing