fix: Gemini and OpenCode provider detection; Cron API key resolution - #5919
Open
kaskabayev wants to merge 1 commit into
Open
fix: Gemini and OpenCode provider detection; Cron API key resolution#5919kaskabayev wants to merge 1 commit into
kaskabayev wants to merge 1 commit into
Conversation
kaskabayev
force-pushed
the
fix/gemini-opencode-detection-and-cron-api-key
branch
from
April 15, 2026 07:50
a0505cc to
9f2e30d
Compare
kaskabayev
force-pushed
the
fix/gemini-opencode-detection-and-cron-api-key
branch
2 times, most recently
from
April 23, 2026 20:02
9e14b86 to
f0915c7
Compare
alt-glitch
added
type/bug
kaskabayev
force-pushed
the
fix/gemini-opencode-detection-and-cron-api-key
branch
2 times, most recently
from
May 20, 2026 18:30
57c3fb1 to
15cf8ad
Compare
kaskabayev
force-pushed
the
fix/gemini-opencode-detection-and-cron-api-key
branch
from
May 20, 2026 18:30
15cf8ad to
5804508
Compare
teknium1
reviewed
Jul 12, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused provider and cron investigation.
Problems
- The provider-overlay portion is now redundant: current main declares Gemini credentials in
hermes_cli/auth.py:237-241and OpenCode Zen/Go credentials inplugins/model-providers/opencode-zen/__init__.py:130-143. - The cron branch reads
job["api_key"], but the supported job creation/storage path has no such field: seecron/jobs.py:945-952,cron/jobs.py:1088-1099, andtools/cronjob_tools.py:667-672. As written, this is dead for normally created jobs. - Please add a regression test around
cron/scheduler.pythat verifies any supported stored-job credential reachesresolve_runtime_provider(explicit_api_key=...).
Suggested changes
- Re-scope to the verified cron path after deciding whether raw stored-job
api_keycompatibility is intended; remove the superseded overlay additions.
Automated hermes-sweeper review.
| } | ||
| if job.get("base_url"): | ||
| runtime_kwargs["explicit_base_url"] = job.get("base_url") | ||
| if job.get("api_key"): |
Contributor
There was a problem hiding this comment.
Current cron job creation and the model-callable cron tool do not define or persist an api_key field (cron/jobs.py:945-952, cron/jobs.py:1088-1099, tools/cronjob_tools.py:667-672). Please establish the supported producer/compatibility contract and add a regression test that proves this value reaches resolve_runtime_provider.
teknium1
added
sweeper:risk-security-boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds provider overlays for Gemini and OpenCode to correctly map them to common environment variables (GOOGLE_API_KEY, OPENCODE_ZEN_API_KEY, OPENCODE_GO_API_KEY). It also fixes a bug in the cron scheduler where the API key from job definitions was not being properly passed to the runtime provider resolution.