simplicio/fix 58672 snapshot keep - #59135
Closed
wesleysimplicio wants to merge 3 commits into
Closed
Conversation
wesleysimplicio
commented
Jul 5, 2026
wesleysimplicio
commented
Contributor
- fix: Groq STT now reads model from config.yaml instead of hardcoding
- fix(update): change pre-update snapshot keep=1 to keep=3 to avoid silently pruning all other snapshots
- fix: preserve save_traces and trace_dir fields in MOA settings save path
The provider branch in was using directly, ignoring any model configured under in config.yaml. All other providers (openai, mistral, elevenlabs) read from their respective config sections. Added the same pattern: look up before falling back to the default constant. Resolves NousResearch#58734
…ently pruning all other snapshots The update process calls create_quick_snapshot(label='pre-update', keep=1), which prunes ALL other quick snapshots (including manual ones) down to just 1 — the one just created. This means any state snapshot the user previously took via /snapshot is silently destroyed on every update. Bump keep to 3 so the most recent pre-update snapshots survive alongside the newest one, giving the user a meaningful recovery window without allowing indefinite accumulation of large state.db copies. Fixes NousResearch#58672
alt-glitch
added
type/bug
Collaborator
Related: this omnibus overlaps two focused open PRs — the Groq STT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.