fix(acp): preserve explicit model providers - #59092
Open
BROCCOLO1D wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the focused ACP fix. Current The PR guards that fallback only for recognized explicit provider prefixes, preserves bare-model autodetection, and updates the shared resolver used by both ACP This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider:modelselections instead of running provider auto-detection over them.Why
session/set_modelcould parseanthropic:claude-sonnet-5correctly, then immediately re-rundetect_provider_for_modelbecause the parsed provider matched the current provider.openrouterand fail sessions without OpenRouter credentials.Changes
acp_adapter/server.py: track provider-qualified ACP model inputs and skip provider auto-detection for explicit provider selections; also normalize current-provider slash form likeanthropic/claude-sonnet-5for ACP callers.tests/acp_adapter/test_acp_commands.py: cover explicit colon and current-provider slash selections, plus the unchanged bare-model auto-detection path.Validation
python -m pytest tests/acp_adapter/test_acp_commands.py -q -o 'addopts='(7 passed)python -m py_compile acp_adapter/server.pygit diff --checkScope
session/set_modelprovider resolution for explicit provider-qualified model inputs./modelslash-command/provider auto-detection behavior tracked by related issues.