fix(email): honor profile secret scope for email adapter env reads

[phantom-instruction-set]

What does this PR do?

The email adapter (plugins/platforms/email/adapter.py) read EMAIL_ADDRESS, EMAIL_PASSWORD, EMAIL_IMAP_HOST, EMAIL_SMTP_HOST, EMAIL_ALLOWED_USERS, and EMAIL_ALLOW_ALL_USERS via os.getenv() directly. In a multiplexed gateway, os.environ holds the default profile's .env values, so every secondary profile inherited the default profile's email credentials instead of its own — the adapter polled the wrong inbox and used the wrong allowlist.

This is a sibling of the api_server env-leak bug (#52307/#50051): the same os.getenv→get_secret migration that PR #50094 applies to gateway/config.py, but for the email adapter itself, which neither PR #50094 nor #51374 covers.

Related Issue

Sibling of #50051 and #52307. Covers the email adapter gap left by PR #50094 (which fixes gateway/config.py only).

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• 🔒 Security fix (prevents cross-profile credential leakage)

Changes Made

• plugins/platforms/email/adapter.py: replace os.getenv with agent.secret_scope.get_secret for all EMAIL_* credential reads (adapter __init__, check_email_requirements, _allowlist_in_effect, _dispatch_message allowlist gate, _send_email SMTP helper, EMAIL_AUTHSERV_ID).
• gateway/config.py: add _getenv/_getenv_str/_getenv_int helpers (from PR fix(gateway): isolate multiplex profile config env reads #50094) and replace os.getenv with _getenv for the email block in _apply_env_overrides.
• tests/gateway/test_email_secret_scope.py: 5 new tests.

How to Test

1. Run the new tests:

python -m pytest tests/gateway/test_email_secret_scope.py -v

Expected: 5 passed.

2. Verify the RED→GREEN cycle: stash the adapter.py change, re-run — 2 tests FAIL. Restore — all 5 pass.

3. Run existing suites (no regressions):

python -m pytest tests/gateway/test_email.py tests/gateway/test_email_robustness.py tests/gateway/test_config.py tests/gateway/test_multiplex_phase0.py tests/agent/test_secret_scope.py -q

Expected: 219 passed.

4. Manual reproduction (multiplexed gateway with a secondary profile):

# Before this PR — secondary profile leaks primary's address:
[Email] Adapter initialized for alpha@test.invalid  ← leaked from os.environ

# After this PR — secondary profile uses its own scoped address:
[Email] Adapter initialized for beta@test.invalid  ← from profile-scoped .env

Checklist

Code

• I've read the Contributing Guide
• Commit messages follow Conventional Commits (fix(email):)
• Searched for existing PRs — fix(gateway): isolate multiplex profile config env reads #50094 and fix(gateway): honor explicit api_server enabled:false under env key #51374 cover gateway/config.py but neither touches plugins/platforms/email/adapter.py
• PR contains only changes related to this fix
• All tests pass (226 passed across affected suites)
• Added tests for changes (5 new tests)
• Tested on Ubuntu 24.04, Python 3.11

Documentation & Housekeeping

• N/A — no config key or architecture changes

[teknium1]

Thanks for isolating the adapter-side gap. The premise is still valid on current main: plugins/platforms/email/adapter.py:437-443 reads email credentials from os.getenv() even though multiplexed adapter creation runs under _profile_runtime_scope() (gateway/run.py:8657-8689), which installs a profile secret scope (gateway/run.py:1441-1472).

Problems

• The gateway/config.py portion is already superseded by 0f154e780e71c74f8a1cdccb25c97a6abd8e5a57: current gateway/config.py:174-204 provides _getenv, and gateway/config.py:1717-1736 already routes the Email block through it.
• The adapter retains direct reads for EMAIL_IMAP_PORT, EMAIL_SMTP_PORT, and EMAIL_POLL_INTERVAL at plugins/platforms/email/adapter.py:440-443, plus EMAIL_TRUST_FROM_HEADER at line 467.
• The new allowlist test only checks a truthy result; its default-profile and scoped values are both nonempty, so it would pass before the migration.

Suggested changes

• Salvage the adapter/test portion only, complete the remaining per-profile EMAIL_* reads, and make the allowlist regression test distinguish scoped from process-global input.

Automated hermes-sweeper review.

[teknium1]

Please complete the scope migration for the adjacent per-profile Email settings too: EMAIL_IMAP_PORT, EMAIL_SMTP_PORT, and EMAIL_POLL_INTERVAL still use env_int, and EMAIL_TRUST_FROM_HEADER still uses env_bool. In multiplex mode those helpers read process-global environment values rather than the profile scope.