fix: pause typing indicator during approval waits - #5893
Merged
Conversation
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
Contributor
|
This was referenced Apr 10, 2026
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
When the agent waits for dangerous-command approval, the typing indicator (_keep_typing loop) kept refreshing. On Slack's Assistant API this is critical: assistant_threads_setStatus disables the compose box, preventing users from typing /approve or /deny. - Add _typing_paused set + pause/resume methods to BasePlatformAdapter - _keep_typing skips send_typing when chat_id is paused - _approval_notify_sync pauses typing before sending approval prompt - _handle_approve_command / _handle_deny_command resume typing after Benefits all platforms — no reason to show 'is thinking...' while the agent is idle waiting for human input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the agent waits for dangerous-command approval, the
_keep_typingloop kept refreshing the typing indicator. On Slack's Assistant API,assistant_threads_setStatusdisables the compose box while active — users literally cannot type/approveor/denyto respond to approval prompts. The approval message send briefly clears the status, but_keep_typingre-sets it within 2 seconds.This was reported by Willard on the Nous Slack.
Changes
gateway/platforms/base.py:_typing_paused: settoBasePlatformAdapter.__init___keep_typingskipssend_typingwhenchat_idis in the paused setpause_typing_for_chat()/resume_typing_for_chat()— thread-safe (CPython GIL)gateway/run.py:_approval_notify_sync: pauses typing before sending the approval prompt_handle_approve_command: resumes typing after approval (agent continues)_handle_deny_command: resumes typing after denial (agent continues with BLOCKED)How it works
_approval_notify_syncfires → typing paused_keep_typingloop continues but skipssend_typing→ compose box stays unlocked/approveor/deny→ handler resumes typing → agent resumesfinallyBenefits all platforms, not just Slack — no reason to show typing while idle.
Tests
All 134 base adapter + Slack tests pass. All 16 non-pre-existing gateway approval tests pass. 6 pre-existing approval E2E failures confirmed unrelated (same on main).