Skip to content

fix(agent): add return_exceptions=True to asyncio.gather in context_references #58808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
x7peeps wants to merge 1 commit into from
Closed

fix(agent): add return_exceptions=True to asyncio.gather in context_references #58808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions agent/context_references.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,15 @@ async def preprocess_context_references_async(
allowed_root=allowed_root_path,
)
for ref in refs
)
),
return_exceptions=True,
)
for warning, block in expanded:
for item in expanded:
# Filter out exceptions from return_exceptions=True
if isinstance(item, BaseException):
warnings.append(f"@ context expansion failed: {item}")
continue
warning, block = item
if warning:
warnings.append(warning)
if block:
Expand Down
Loading