Skip to content

fix(stt): read Groq model from stt.groq.model config before env fallback #58765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liuhao1024 wants to merge 1 commit into from
Closed

fix(stt): read Groq model from stt.groq.model config before env fallback #58765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/tools/test_transcription_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,17 @@ def test_default_model_used_when_none(self, sample_ogg):

assert mock_groq.call_args[0][1] == DEFAULT_GROQ_STT_MODEL

def test_config_groq_model_used(self, sample_ogg):
config = {"groq": {"model": "whisper-large-v3"}}
with patch("tools.transcription_tools._load_stt_config", return_value=config), \
patch("tools.transcription_tools._get_provider", return_value="groq"), \
patch("tools.transcription_tools._transcribe_groq",
return_value={"success": True, "transcript": "hi"}) as mock_groq:
from tools.transcription_tools import transcribe_audio
transcribe_audio(sample_ogg, model=None)

assert mock_groq.call_args[0][1] == "whisper-large-v3"

def test_config_local_model_used(self, sample_ogg):
config = {"local": {"model": "small"}}
with patch("tools.transcription_tools._load_stt_config", return_value=config), \
Expand Down
3 changes: 2 additions & 1 deletion tools/transcription_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,8 @@ def transcribe_audio(file_path: str, model: Optional[str] = None) -> Dict[str, A
return _transcribe_local_command(file_path, model_name)

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stt.groq: null is valid YAML and makes this expression return None, so the next groq_cfg.get(...) raises AttributeError. Please match the null-safe sibling-provider pattern introduced in 3a394210: stt_config.get("groq") or {}, with a regression test for the null subsection.

if provider == "groq":
model_name = model or DEFAULT_GROQ_STT_MODEL
groq_cfg = stt_config.get("groq", {})
model_name = model or groq_cfg.get("model", DEFAULT_GROQ_STT_MODEL)
return _transcribe_groq(file_path, model_name)

if provider == "openai":
Expand Down
Loading