fix(memory): guard local uploads against credential reads - #58751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #57841 by @necoweb3 (cherry-picked onto current main, authorship preserved). Memory-provider local upload tools now route model-supplied local paths through the shared
agent.file_safety.raise_if_read_blocked()guard before reading bytes, so credential stores (~/.hermes/auth.json,.env, etc.) can no longer leave the machine via memory-backend upload APIs.Changes
plugins/memory/retaindb/__init__.py:retaindb_upload_filecalls the read guard beforeread_bytes(); blocked paths return a clear error.plugins/memory/openviking/__init__.py:viking_add_resourceguards single-file uploads;_zip_directoryskips read-denied files when building directory archives (symlinks were already skipped).Validation
tests/plugins/memory/test_retaindb_provider.py+test_openviking_provider.pyPlugin-directories-only diff — no core files touched. Same defense-in-depth chokepoint as #57698 (image/video-gen) and #58709 (vision/video analyze).
Closes #57841.
Infographic