Skip to content

fix(dashboard): skip auto-sso for password auth - #58400

Closed
ai-hand wants to merge 1 commit into
NousResearch:mainfrom
ai-hand:fix/dashboard-basic-auth-auto-sso
Closed

fix(dashboard): skip auto-sso for password auth#58400
ai-hand wants to merge 1 commit into
NousResearch:mainfrom
ai-hand:fix/dashboard-basic-auth-auto-sso

Conversation

@ai-hand

@ai-hand ai-hand commented Jul 4, 2026

Copy link
Copy Markdown

Summary

  • Avoid auto-SSO redirects for password-only dashboard auth providers
  • Let the /login page render the username/password form instead of calling OAuth start_login() on the basic provider
  • Add regression coverage for single password-provider dashboard auth

Test Plan

  • python -m pytest tests/hermes_cli/test_dashboard_auth_401_reauth.py::TestAutoSsoRedirect tests/plugins/dashboard_auth/test_basic_provider.py -q -o 'addopts='

@alt-glitch alt-glitch added type/bug Something isn't working comp/dashboard Web dashboard / control panel UI (dashboard/, landing) area/auth Authentication, OAuth, credential pools P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jul 4, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #54887 (earliest-open canonical fix). This PR adds the byte-for-byte identical if getattr(provider, "supports_password", False): return None guard in _auto_sso_response() (hermes_cli/dashboard_auth/middleware.py) as #54887, into which several siblings (#54958, #58007, #57427) already dedup. Related to merged regression source #54846 and the broader-scope sibling #58171.

@teknium1

teknium1 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Closing as a duplicate — #54887 (opened Jun 29) is the earliest canonical PR for this fix and contains the byte-identical supports_password guard in _auto_sso_response(). Nothing here to salvage on top of it; the triage bot already linked the sibling duplicates (#54958/#58007/#57427). Thanks for the report regardless.

@teknium1 teknium1 closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/dashboard Web dashboard / control panel UI (dashboard/, landing) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants