fix(tools): add actionable guidance to web_search/web_extract error messages - #58359
Open
ms-alan wants to merge 2 commits into
Open
fix(tools): add actionable guidance to web_search/web_extract error messages#58359ms-alan wants to merge 2 commits into
ms-alan wants to merge 2 commits into
Conversation
added 2 commits
July 5, 2026 00:10
Closes NousResearch#58239 himalaya v1.2.0 uses positional arguments for flag names (not --flag). Fixed: 'himalaya flag add 42 seen' (was: 'himalaya flag add 42 --flag seen') Fixed: 'himalaya flag remove 42 seen' (was: 'himalaya flag remove 42 --flag seen')
…able guidance Closes NousResearch#58320 - web_search "no provider configured" error now suggests: 'pip install ddgs (no API key required)' as a free no-config option - web_extract "no content" error now suggests: 'Check cache/web/' and 'Use browser_navigate' as fallbacks - web_extract "no provider" error now adds 'Run `hermes tools` to configure'
alt-glitch
added
type/feature
ghost
mentioned this pull request
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for improving the failure guidance. The premise remains valid on current main: the targeted generic branches are still present at tools/web_tools.py:714, tools/web_tools.py:922, and tools/web_tools.py:1020.
Problems
tools/web_tools.py:1020handles an emptyresultslist. The onlycache/webwrite is in_truncate_with_footer()after nonempty content exceeds the limit (tools/web_tools.py:547), so this failure cannot leave cached extracted content to inspect.browser_navigateis not present in the standalonewebtoolset (toolsets.py:97-100), so it should not be an unconditional recovery instruction.
Suggested changes
- Replace the cache instruction with an empty-result-appropriate retry/provider diagnostic, and make any browser fallback conditional on browser availability.
- Add focused coverage for the no-provider and empty-results response paths.
This is an automated hermes-sweeper review.
| @@ -925,7 +926,11 @@ async def web_extract_tool( | |||
| trimmed_response = {"results": trimmed_results} | |||
|
|
|||
| if trimmed_response.get("results") == []: | |||
Contributor
There was a problem hiding this comment.
This branch runs only when the provider returned no results. cache/web is written only after nonempty content is truncated, so there cannot be cached extracted content to inspect here; please replace this with an empty-result-appropriate recovery step.
teknium1
added
sweeper:risk-compatibility
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58320
Improves error messages returned by web_search and web_extract tools when they fail, giving users actionable next steps.
Changes:
pip install ddgsas a free no-API-key option alongsidehermes toolsRunhermes toolsto configure