fix(tui): keep process notifications out of agent turns - #58349
Open
iwillwill-ALLWILL wants to merge 1 commit into
Open
fix(tui): keep process notifications out of agent turns#58349iwillwill-ALLWILL wants to merge 1 commit into
iwillwill-ALLWILL wants to merge 1 commit into
Conversation
Collaborator
Related to the notify_on_complete/process-notification family: #35317 (queued input pollution), #41875 (CLI direct-display), #35667 (owner-scoped TUI routing), and the #15248 root issue. This PR takes a distinct angle — keeping background process completion/watch notifications as UI-only status (not synthetic user turns) while preserving async delegation completions as chainable follow-up turns. Not a duplicate; cross-linking so a maintainer can pick the canonical direction across this cluster. |
iwillwill-ALLWILL
force-pushed
the
fix/tui-process-notifications-status-only
branch
from
July 5, 2026 07:46
cd8ae17 to
9dfb3f5
Compare
This was referenced Jul 10, 2026
Contributor
|
Thanks for isolating the process-notification/agent-turn boundary; the underlying behavior remains present on current main. Problems
Suggested changes
Automated hermes-sweeper review. |
iwillwill-ALLWILL
force-pushed
the
fix/tui-process-notifications-status-only
branch
from
July 18, 2026 15:47
9dfb3f5 to
b55c5c0
Compare
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatch_turn_idstill owns the current real user turn.Reimplementation
This replaces the previous patch with a clean implementation on current
main(b1fc65308). It addresses the sweeper feedback on both modern TUI delivery paths and adds the equivalent stale-delegation guard to classic CLI.The implementation is fail-closed: missing, restored, or stale turn tokens may still surface as status, but cannot create a new agent turn.
Verification
504 passedacross the affected CLI, goal, delegation, TUI gateway, queued-prompt, and compute-host suites.ruff check .python3 scripts/check-windows-footguns.py --allgit diff --checkRegression coverage
Includes coverage for: