-
Notifications
You must be signed in to change notification settings - Fork 52.6k
feat(achievements): add export endpoint and agent summary (#18472) #58015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rlaope
wants to merge
7
commits into
NousResearch:main
Choose a base branch
from
rlaope:feat/achievements-export-agent-summary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+455
−1
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d9945c
feat(achievements): add export endpoint and agent summary (#18472)
rlaope 959e62d
docs: document achievements export and agent summary
rlaope da4080c
test(achievements): cover export and summary endpoints at the route l…
rlaope 8b60965
Merge remote-tracking branch 'origin/main' into feat/achievements-exp…
rlaope 7ddc86e
fix(achievements): pass encoding to agent-summary read/write for Windows
rlaope fe57d44
Merge main and address review feedback for PR #58015
rlaope 5e6c091
Merge remote-tracking branch 'origin/main' into feat/achievements-exp…
rlaope File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update
website/docs/user-guide/features/built-in-plugins.mdtoo. Its canonical achievements API/state-file tables currently end at/reset-stateandscan_checkpoint.json, so this route andagent_summary.jsonwould be undocumented there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the canonical built-in plugin page in commit 959e62d. The achievements API table now documents GET /achievements/summary and GET /export with its format/state parameters, and the state-file table includes agent_summary.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rechecked after the update in
fe57d445c281ef6e756fef3adfa384fc5b6c72d9. Rechecked the review requests after integration: canonical documentation inwebsite/docs/user-guide/features/built-in-plugins.mdincludes/achievements/summary,/export, andagent_summary.json; endpoint tests exercise the route functions. The summary writer now uses upstream_write_json()and the plugin data-directory helpers, with reset-state cleanup retained.The relevant checks listed in the PR update were rerun successfully. Leaving thread resolution to you; this reply is not a claim of upstream CI approval.