fix: scope kanban auto-subscriptions to active profile - #57995
Closed
tymrtn wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_SESSION_PROFILE/HERMES_PROFILEbehavior when presentFixes #57993.
Why
In multi-bot installs,
telegram:<chat_id>is not a complete delivery identity. If a Kanban notification subscription is written withnotifier_profile=None, another profile's Telegram gateway that shares the same human chat can claim and deliver the task's terminal event.The notifier already respects
notifier_profile; this patch makes the auto-subscribe path reliably populate it fromget_active_profile_name()as a fallback.Tests
scripts/run_tests.sh tests/tools/test_kanban_tools.py tests/gateway/test_kanban_notifier.py— 105 passedpython -m pytest tests/tools/test_kanban_tools.py -q— 98 passed (Codex review lane)python -m pytest tests/hermes_cli/test_kanban_notify.py tests/gateway/test_kanban_notifier.py -q— 19 passed (Codex review lane)git diff --checkReview
Codex reviewed the uncommitted diff and reported no blocking correctness issues.