fix: dashboard basic auth (password-only provider) no longer crashes on first page load (#57868) - #57959
Closed
Sahil-SS9 wants to merge 1 commit into
Closed
Conversation
…on first page load (NousResearch#57868)
Collaborator
Duplicate of #54887 (earliest open canonical fix). This PR applies the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57868
Description
When the dashboard is bound to a non-loopback host and the only enabled interactive auth provider is a password-only provider (e.g. the bundled plugin), unauthenticated users are redirected to , which then crashes with a 500 Internal Server Error because the basic-auth provider has no OAuth redirect flow.
The fix adds a guard in to avoid auto-redirecting to when the sole provider is password-only, falling through to render the interstitial instead.
Verification