fix: sync bundled skills to all profiles during update - #5795
Merged
Conversation
…d profile The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
tetrabit
pushed a commit
to tetrabit/hermes-agent
that referenced
this pull request
Apr 7, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…d profile (NousResearch#5795) The filter in cmd_update() excluded is_default profiles from the cross-profile skill sync loop. When running 'hermes update' from a named profile (e.g. hermes -p coder update), the default profile (~/.hermes) never received new bundled skills. Remove the 'not p.is_default' condition so all profiles — including default — are synced regardless of which profile runs the update. Reported by olafgeibig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
hermes updatefrom a named profile, the default profile (~/.hermes) was excluded from the cross-profile bundled skill sync. The filternot p.is_default and p.name != activemeant the default profile never appeared in the "other profiles" list.One-line fix: remove
not p.is_default andso all profiles (including default) receive bundled skill updates regardless of which profile runs the update.What changed
hermes_cli/main.py: Changed the profile filter incmd_update()'s skill sync loop fromnot p.is_default and p.name != activetop.name != activeTest plan
tests/hermes_cli/test_cmd_update.py— 14 passedtests/tools/test_skills_sync.py— 22 passedtests/hermes_cli/test_profiles.py— 80 passedReported by olafgeibig.