You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_detect_venv_python_processes() treated noisy Windows system process cwd/cmdline metadata as proof of a Hermes venv holder, even when the executable was a system process.
Thanks for the focused Windows update fix. Current main still promotes any process whose cmdline contains the venv path (hermes_cli/main.py:9082) or whose hermes_cli.main invocation has a cwd under the install root (hermes_cli/main.py:9084-9086), matching the failure mode reported in #57829. The PR filters the reported system-process class before those fallbacks and its added test retains detection of the user-space Python trampoline.
Rebased the original focused fix onto current main (1f89f3102f) and force-pushed the PR branch as 50ea329ab4. The implementation still filters the Windows system-process class before the venv/cwd fallbacks, while retaining the user-space Python trampoline regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/install-updateInstaller, updater, packaging, wheels, doctorcomp/cliCLI entry point, hermes_cli/, setup wizardP2Medium — degraded but workaround existsplatform/windowsNative Windows-specific behavior or breakagesweeper:blast-moderateSweeper blast radius: moderate — a subsystem or single platformsweeper:risk-platform-windowsSweeper risk: may break or behave differently on native Windowstype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
_detect_venv_python_processes()treated noisy Windows system process cwd/cmdline metadata as proof of a Hermes venv holder, even when the executable was a system process.Tests
python -m pytest tests/hermes_cli/test_update_venv_health.py -qpython -m py_compile hermes_cli/main.py tests/hermes_cli/test_update_venv_health.pygit diff --checkFixes #57829