Skip to content

fix(agent): prefer native vision over auxiliary fallback in auto mode (#29135) - #57650

Merged
teknium1 merged 1 commit into
mainfrom
fix/native-vision-before-aux
Jul 3, 2026
Merged

fix(agent): prefer native vision over auxiliary fallback in auto mode (#29135)#57650
teknium1 merged 1 commit into
mainfrom
fix/native-vision-before-aux

Conversation

@teknium1

@teknium1 teknium1 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

image_input_mode: auto now prefers native vision when the main model supports it; an explicit auxiliary.vision config acts as a fallback for text-only main models instead of unconditionally forcing the lossy text pipeline. Fixes #29135 and the bug half of #44299 (also reported in #53400 / #48964).

Root cause: decide_image_input_mode() checked _explicit_aux_vision_override(cfg) before _lookup_supports_vision(), so any user with an auxiliary.vision block configured lost native pixels even on a fully vision-capable main model.

Changes

Validation

Test file Result
tests/agent/test_image_routing.py pass
tests/agent/test_custom_providers_vision.py pass

Closes #29135, #44299, #53400, #48964. Salvages #32519 (canonical earliest PR; #44320, #44305, #44450 were duplicates already closed against it) with contributor authorship preserved.

Infographic

native-vision-first

@alt-glitch alt-glitch added type/bug Something isn't working comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint tool/vision Vision analysis and image generation P2 Medium — degraded but workaround exists labels Jul 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Core-team salvage (@teknium1) of the earliest canonical PR #32519 (@Jiahui-Gu), authorship preserved. Closes the bug/feature cluster #29135, #44299, #53400, #48964. Distinct from the additive native_first opt-in mode PR #57297 (new mode vs. reordering auto). Related, not duplicate — this is the canonical fix; the salvaged/competing items can be closed in its favor by a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image auto-routing cannot use native vision when auxiliary.vision is configured as fallback

3 participants