Skip to content

feat(cli): forward --skills flag in ACP mode - #57511

Closed
NakePranob wants to merge 1 commit into
NousResearch:mainfrom
NakePranob:feat/acp-cli-skills
Closed

feat(cli): forward --skills flag in ACP mode#57511
NakePranob wants to merge 1 commit into
NousResearch:mainfrom
NakePranob:feat/acp-cli-skills

Conversation

@NakePranob

@NakePranob NakePranob commented Jul 3, 2026

Copy link
Copy Markdown

Description

Forward the --skills flag from the hermes acp CLI command to the ACP adapter's argument parser, enabling users to preload skills when launching the ACP server.

hermes acp --skills "my-skill" --skills "another-skill"
# or comma-separated:
hermes acp --skills "my-skill,another-skill"

Changes

  • hermes_cli/main.py — forward args.skills to acp_main()

1 file, +3 lines.

Related

@alt-glitch alt-glitch added type/feature New feature or request comp/cli CLI entry point, hermes_cli/, setup wizard comp/acp Agent Communication Protocol adapter tool/skills Skills system (list, view, manage) P3 Low — cosmetic, nice to have labels Jul 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related: #24466 (issue), #30560 (open competing PR). #30560 is the broader canonical fix — it forwards --skills from the CLI AND plumbs the skills through the full ACP stack (entry → HermesACPAgent → SessionManager → build_preloaded_skills_prompt) with tests. This PR is a subset (the CLI-forward half only), so it's related rather than a duplicate; a human should pick one path.

@NakePranob

Copy link
Copy Markdown
Author

Thanks for the triage, @alt-glitch. Agreed that #30560 covers the same ground more broadly.

We intentionally scoped this PR to the CLI layer only because:

So #57511 (CLI-forward) + #57510 (adapter plumbing) together deliver the same outcome as #30560, just split across two focused PRs. Marking as related rather than duplicate.

Updated the PR body to clarify this relationship.

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for isolating the CLI handoff. The reported gap is present on current main, but this change is not functional by itself.

Problems

  • hermes_cli/main.py:12815-12826 currently drops args.skills, so the premise is valid. However, the proposed forwarded --skills is not accepted by acp_adapter/entry.py:116-146; its parser defines no such argument and calls parse_args() at line 146.
  • The documented hermes acp --skills ... form is also not parsed by the ACP subcommand: hermes_cli/subcommands/acp.py:14-52 declares no --skills flag.
  • Even after parsing, current ACP startup constructs HermesACPAgent() without startup skills (acp_adapter/entry.py:260), and session agent construction has no preload-prompt input (acp_adapter/session.py:584-645).

Suggested changes

  • Integrate this handoff with the adapter/session preload path described in companion #57510 (or the broader #30560), and add an end-to-end regression test that verifies the startup skill reaches ACP session construction.
  • Support or correct the post-subcommand syntax shown in the PR body.

Automated hermes-sweeper review.

Comment thread hermes_cli/main.py
acp_argv.append("--setup-browser")
if getattr(args, "assume_yes", False):
acp_argv.append("--yes")
if getattr(args, "skills", None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current acp_adapter.entry._parse_args() has no --skills argument (acp_adapter/entry.py:116-146), so this makes globally supplied skills fail argument parsing rather than preload them. Please land this with the adapter/session parser and injection path, plus coverage.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 15, 2026
@NakePranob

Copy link
Copy Markdown
Author

ปิด PR นี้ตามคำขอ (no longer needed / cleanup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/acp Agent Communication Protocol adapter comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/skills Skills system (list, view, manage) type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants