fix: persist rotated compression transcripts - #57508
Closed
rayjun wants to merge 1 commit into
Closed
Conversation
2 tasks
Collaborator
|
Fixed on Your PR and #57531 were independent fixes for the same root cause (shallow Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a rotated-compression persistence gap introduced by the intrinsic
_db_persistedmarker. When compression rotates into a child session, protected head/tail messages are shallow-copied into the compressed transcript. If those source dictionaries were already persisted in the parent session, the copied_db_persistedmarker makes the child-session flush skip them, so the rotated transcript can lose live context.This strips persistence-only markers from messages copied into a newly compressed transcript, while leaving in-place compaction semantics unchanged.
Related Issue
Fixes #57491
Type of Change
Changes Made
agent/context_compressor.pytests/run_agent/test_compression_persistence.pyHow to Test
python -m pytest tests/run_agent/test_compression_persistence.py tests/agent/test_codex_app_server_persist.py -qpython -m pytest tests/agent/test_context_compressor.py tests/agent/test_context_compressor_session_end_clears_state.py tests/agent/test_context_compressor_temporal_anchoring.py tests/agent/test_context_compressor_summary_continuity.py tests/agent/test_context_compressor_cross_session_guard.py tests/run_agent/test_compression_persistence.py -q_db_persistedinto the child session and the child session receives the compressed transcript rows.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs