Conversation
Competing open fixes for #57247 (unquoted
Same goal, different quoting mechanism — |
Collaborator
|
Thanks for addressing the real spaced-path installer failure: current main still writes the POSIX override unquoted at Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57247.
Summary
AGENT_BROWSER_EXECUTABLE_PATHwhen installers persist explicit browser overrides to.envDuplicate check
AGENT_BROWSER_EXECUTABLE_PATHinstaller changes before openingTests
.venv/bin/python -m pytest tests/test_install_sh_browser_install.py -q -k "browser_override or snap".venv/bin/python -m pytest tests/test_install_sh_browser_install.py -q.venv/bin/python -m ruff check tests/test_install_sh_browser_install.pyscripts/run_tests.sh tests/test_install_sh_browser_install.py -qNote:
pwshis not installed in this local environment, so the PowerShell installer assertion is text-level coverage.