Skip to content

fix(dashboard-auth): catch NotImplementedError in auth_login for password-only providers #57445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benskls wants to merge 1 commit into from
Closed

fix(dashboard-auth): catch NotImplementedError in auth_login for password-only providers #57445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions hermes_cli/dashboard_auth/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ async def auth_login(request: Request, provider: str, next: str = ""):

try:
ls = p.start_login(redirect_uri=_redirect_uri(request))
except NotImplementedError:
# Password-only providers (e.g. BasicAuthProvider) do not support
# OAuth redirect flows. Redirect to the server-rendered login
# page instead of crashing with a 500.
from urllib.parse import quote

next_path = request.query_params.get("next", "")
safe = _validate_post_login_target(next_path)
target = f"/login?next={quote(safe, safe='')}" if safe else "/login"
return RedirectResponse(url=target, status_code=302)
except ProviderError as e:
audit_log(
AuditEvent.LOGIN_FAILURE,
Expand Down