Skip to content

fix(dashboard-auth): skip OAuth redirect for password-only providers in auto-SSO #57402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cliffsch wants to merge 1 commit into from
Closed

fix(dashboard-auth): skip OAuth redirect for password-only providers in auto-SSO #57402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions hermes_cli/dashboard_auth/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,15 @@ def _auto_sso_response(request: Request) -> Response | None:
# Zero → nothing to redirect to. Two+ → user must choose at /login.
return None

from hermes_cli.dashboard_auth.prefix import prefix_from_request

provider = providers[0]

# Password-only providers (e.g. basic auth) don't have an OAuth flow;
# /auth/login?provider=<name> would raise NotImplementedError.
# Fall through to the server-rendered /login page instead.
if getattr(provider, "supports_password", False):
return None

from hermes_cli.dashboard_auth.prefix import prefix_from_request
prefix = prefix_from_request(request)
next_param = _safe_next_target(request)
from urllib.parse import quote
Expand Down