You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related (not duplicate) to the dashboard password-only auth 500 cluster (regression from merged #54846). This PR fixes the /auth/loginroute (routes.py) by 302-redirecting supports_password providers to the /login page (preserving a validated next + X-Forwarded-Prefix) rather than calling OAuth-only start_login(). That is a different mechanism from:
Complementary approaches for the same symptom; flagging the #54887 / #56666 / #57396 cluster (issues #55130, #56067) so a maintainer can pick one. Note this PR also bundles an unrelated ui-tui/src/app/usePet.ts typed-RPC-guard change.
Thanks for the focused dashboard-auth fix. This is already implemented on current main; the later implementation also preserves the intended central TUI RPC guard.
Automated hermes-sweeper review evidence:
hermes_cli/dashboard_auth/routes.py:195-202 checks supports_password, validates next, retains _prefix(request), and redirects to /login before start_login().
tests/hermes_cli/test_dashboard_auth_password_login.py:211-217 already directly covers the password-provider /auth/login redirect.
ui-tui/src/app/usePet.ts:197 uses the shared rpc helper; ui-tui/src/app/useMainApp.ts:450-467 validates its gateway result with asRpcResult and handles failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/authAuthentication, OAuth, credential poolscomp/dashboardWeb dashboard / control panel UI (dashboard/, landing)comp/tuiTerminal UI (ui-tui/ + tui_gateway/)P2Medium — degraded but workaround existssweeper:implemented-on-mainSweeper: behavior already present on current maintype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/auth/loginto the password login page instead of invoking OAuth-onlystart_login()nexttargets and reverse-proxyX-Forwarded-Prefixon that redirectTests
scripts/run_tests.sh tests/hermes_cli/test_dashboard_auth_password_login.pynpm run typecheck --workspace ui-tuinpm exec --workspace ui-tui -- eslint src/app/usePet.tsnpm test --workspace ui-tui -- --run src/__tests__/rpc.test.tsgit diff --check