Skip to content

fix: handle password auth login redirects - #57396

Closed
Seyferkun wants to merge 1 commit into
NousResearch:mainfrom
Seyferkun:fix/password-login-pet-rpc
Closed

fix: handle password auth login redirects#57396
Seyferkun wants to merge 1 commit into
NousResearch:mainfrom
Seyferkun:fix/password-login-pet-rpc

Conversation

@Seyferkun

Copy link
Copy Markdown

Summary

  • Redirect password-capable dashboard auth providers from /auth/login to the password login page instead of invoking OAuth-only start_login()
  • Preserve validated next targets and reverse-proxy X-Forwarded-Prefix on that redirect
  • Route TUI pet RPC calls through the typed gateway request/result guard

Tests

  • scripts/run_tests.sh tests/hermes_cli/test_dashboard_auth_password_login.py
  • npm run typecheck --workspace ui-tui
  • npm exec --workspace ui-tui -- eslint src/app/usePet.ts
  • npm test --workspace ui-tui -- --run src/__tests__/rpc.test.ts
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/tui Terminal UI (ui-tui/ + tui_gateway/) area/auth Authentication, OAuth, credential pools labels Jul 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related (not duplicate) to the dashboard password-only auth 500 cluster (regression from merged #54846). This PR fixes the /auth/login route (routes.py) by 302-redirecting supports_password providers to the /login page (preserving a validated next + X-Forwarded-Prefix) rather than calling OAuth-only start_login(). That is a different mechanism from:

Complementary approaches for the same symptom; flagging the #54887 / #56666 / #57396 cluster (issues #55130, #56067) so a maintainer can pick one. Note this PR also bundles an unrelated ui-tui/src/app/usePet.ts typed-RPC-guard change.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused dashboard-auth fix. This is already implemented on current main; the later implementation also preserves the intended central TUI RPC guard.

Automated hermes-sweeper review evidence:

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants