Fix image_generate per-call provider/model overrides - #57293
Closed
lkz-de wants to merge 5 commits into
Closed
Conversation
lkz-de
force-pushed
the
lkz/image-generate-per-call-overrides-followup
branch
from
July 3, 2026 03:07
dcda87a to
7448c29
Compare
lkz-de
force-pushed
the
lkz/image-generate-per-call-overrides-followup
branch
2 times, most recently
from
July 5, 2026 21:02
8b50ebc to
5e1e1de
Compare
lkz-de
force-pushed
the
lkz/image-generate-per-call-overrides-followup
branch
from
July 6, 2026 14:33
5e1e1de to
4c933bd
Compare
This was referenced Jul 6, 2026
Contributor
Author
|
Splitting this into two narrower follow-up PRs for cleaner review:
I’m closing this combined PR in favor of those two split PRs so each lane can be reviewed independently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider/modeloverride support forimage_generateand thread those overrides through the FAL path end-to-endprovider: moa/moa <prompt>one-shot behavior while stopping implicit or durable default switching into MoAprovider/modeloverride args and preserve theimage_generateresponse-field wording around the returnedimageWhy
On current
origin/main,image_generatestill lacks the full per-call override flow and the branch also needs follow-up policy enforcement around FAL fallback behavior and MoA persistence.This PR lands the override support and the follow-up policy fixes together:
What changed
Image generation / FAL
provider/modeloverride surface and thread it throughimage_generate_resolve_fal_model(...)so unknown explicit per-call FAL model overrides emit a warning and fall back to the default FAL modelmodeloverrides throughplugins/image_gen/fal/__init__.pyimage_generateresponse-field wordingMoA policy
provider == "moa"/moa <prompt>as a one-shot path by leaving that path available while preventing default-routing changes into MoAVerification
pytest -q tests/hermes_cli/test_model_switch_moa_policy.py tests/hermes_cli/test_web_server_moa_policy.py tests/tui_gateway/test_goal_command.py::test_moa_bare_returns_usage tests/tui_gateway/test_goal_command.py::test_moa_arg_is_always_one_shot -o addopts=''6 passedpytest -q tests/tools/test_image_generation.py tests/tools/test_image_generation_plugin_dispatch.py -k 'fal or override or model' -o addopts=''32 passed, 39 deselectedpython3 -m py_compile cli.py hermes_cli/model_switch.py hermes_cli/web_server.py plugins/image_gen/fal/__init__.py tools/image_generation_tool.py tui_gateway/server.py tests/hermes_cli/test_model_switch_moa_policy.py tests/hermes_cli/test_web_server_moa_policy.py tests/tools/test_image_generation.py tests/tools/test_image_generation_plugin_dispatch.pyNotes