Skip to content

fix(test-runner): handle Windows path lists safely - #57261

Closed
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-windows-parallel-runner-paths
Closed

fix(test-runner): handle Windows path lists safely#57261
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-windows-parallel-runner-paths

Conversation

@tianma-if

Copy link
Copy Markdown
Contributor

Fixes #57149.

Summary

  • split runner path lists without treating Windows drive-letter colons as separators
  • keep CI-generated colon-joined relative file lists working when Windows uses ; as os.pathsep
  • replace unencodable progress glyphs on legacy Windows pipes so done callbacks do not emit UnicodeEncodeError tracebacks

Tests

  • .venv/bin/python -m pytest tests/test_run_tests_parallel.py -q -k "path_list or progress_print or bare_value"
  • .venv/bin/python -m pytest tests/test_run_tests_parallel.py -q
  • .venv/bin/python -m ruff check scripts/run_tests_parallel.py tests/test_run_tests_parallel.py
  • scripts/run_tests.sh tests/test_run_tests_parallel.py -q

@alt-glitch alt-glitch added type/bug Something isn't working platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jul 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #57152 — both fix #57149 in scripts/run_tests_parallel.py with the same two changes (Windows drive-letter-safe path-list split + UTF-8/errors='replace' progress output). Same code-site and mechanism, different helper names. #57152 is the earliest open.

@tianma-if

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #57152 per triage; the earlier PR covers the same Windows path-list/test-runner fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run_tests_parallel.py on Windows: ':' path-list split breaks drive letters; per-file progress lines lost to UnicodeEncodeError on piped stdout

2 participants