Repository navigation
fix(toolsets): validate dynamic hermes-<platform> toolsets for plugin platforms - #57230
Draft
sonisoft-cnanda wants to merge 1 commit into
Draft
sonisoft-cnanda wants to merge 1 commit into
sonisoft-cnanda wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
… platforms `resolve_toolset` generates a dynamic `hermes-<platform>` toolset for plugin platforms (core tools + any tool registered under the platform's name), but `validate_toolset` had no matching branch. Built-in platforms (telegram/discord/slack) validate via their static `TOOLSETS` entries, but plugin platforms (e.g. teams, google_chat) do not. As a result, callers that gate on `validate_toolset` before resolving — notably `model_tools._get_tools` — treat `hermes-teams` as an unknown toolset and silently drop it, so any tool a plugin platform registers under its own toolset never reaches the model. (Core tools still arrive via other inferred toolsets, which masks the bug.) This surfaced when a plugin platform shipped its first tool. Fix: mirror `resolve_toolset`'s dynamic handling in `validate_toolset` — accept `hermes-<platform>` when the platform is registered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sonisoft-cnanda
force-pushed
the
fix/validate-toolset-plugin-platforms
branch
from
July 2, 2026 18:01
ebc4485 to
d52572a
Compare
Collaborator
|
Thanks for tracing this through the validation gate. The premise reproduces on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
teknium1
added
sweeper:risk-compatibility
12 of 13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_toolsetgenerates a dynamichermes-<platform>toolset for plugin platforms (core tools + any tool registered under the platform's name), butvalidate_toolsethas no matching branch. Built-in platforms (telegram/discord/slack) validate via their staticTOOLSETSentries; plugin platforms (e.g.teams,google_chat) do not.Because callers gate on
validate_toolsetbefore resolving — notablymodel_tools._get_tools(the loop mappingenabled_toolsets→ tool schemas) —hermes-<platform>is treated as an unknown toolset and silently dropped. Any tool a plugin platform registers under its own toolset therefore never reaches the model. Core tools still arrive via other inferred toolsets, which masks the bug. Surfaced when a plugin platform shipped its first model tool.Fix: mirror
resolve_toolset's dynamic handling invalidate_toolset— accepthermes-<platform>when that platform is registered inplatform_registry.Config-only workaround for operators:
platform_toolsets.<platform>: [hermes-<platform>, <platform>].