fix(slack): delete stale progress messages - #57196
Conversation
|
Thanks for the focused Slack cleanup implementation. Current main confirms the premise: The proposed Slack call follows the existing workspace-aware client resolution in Automated hermes-sweeper review. |
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as 'Minseo-Choi' — trac3r00's display name, same account) - 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267) - hello@jeromeiveson.com -> Trantor-develops (#57196) - boumagent@gmail.com -> patp (#18859) - dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as 'Minseo-Choi' — trac3r00's display name, same account) - 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267) - hello@jeromeiveson.com -> Trantor-develops (#57196) - boumagent@gmail.com -> patp (#18859) - dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as 'Minseo-Choi' — trac3r00's display name, same account) - 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267) - hello@jeromeiveson.com -> Trantor-develops (#57196) - boumagent@gmail.com -> patp (#18859) - dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
|
Merged via #70189 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your stale-progress deletion was cherry-picked. Thanks for the contribution! |
- rt.cms012@gmail.com -> trac3r00 (NousResearch#68378; commit authored as 'Minseo-Choi' — trac3r00's display name, same account) - 15167896+2001Y@users.noreply.github.com -> 2001Y (NousResearch#64267) - hello@jeromeiveson.com -> Trantor-develops (NousResearch#57196) - boumagent@gmail.com -> patp (NousResearch#18859) - dorukardahan@hotmail.com -> dorukardahan (NousResearch#17184) was already mapped.
Summary\n- implement SlackAdapter.delete_message via chat.delete so cleanup_progress can remove temporary Working/tool-progress bubbles after the final response lands\n- treat Slack ok=false responses as best-effort cleanup failures instead of successful deletion\n- add Slack adapter tests plus a Slack-specific gateway cleanup_progress regression test\n\n## Verification\n- /Users/virtualmachine/.hermes/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_slack.py tests/gateway/test_run_cleanup_progress.py -q -o 'addopts='\n - 227 passed, 38 existing AsyncMock warnings\n\n## Operational note\n- Slack chat.delete uses the existing chat:write bot scope for messages posted by the bot; no manifest/scope change required. Gateway restart is still required for the live adapter/config change to take effect.