Skip to content

fix(slack): delete stale progress messages - #57196

Closed
Trantor-develops wants to merge 1 commit into
NousResearch:mainfrom
Trantor-develops:kanban/t_01c80099-slack-progress-cleanup
Closed

fix(slack): delete stale progress messages#57196
Trantor-develops wants to merge 1 commit into
NousResearch:mainfrom
Trantor-develops:kanban/t_01c80099-slack-progress-cleanup

Conversation

@Trantor-develops

Copy link
Copy Markdown
Contributor

Summary\n- implement SlackAdapter.delete_message via chat.delete so cleanup_progress can remove temporary Working/tool-progress bubbles after the final response lands\n- treat Slack ok=false responses as best-effort cleanup failures instead of successful deletion\n- add Slack adapter tests plus a Slack-specific gateway cleanup_progress regression test\n\n## Verification\n- /Users/virtualmachine/.hermes/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_slack.py tests/gateway/test_run_cleanup_progress.py -q -o 'addopts='\n - 227 passed, 38 existing AsyncMock warnings\n\n## Operational note\n- Slack chat.delete uses the existing chat:write bot scope for messages posted by the bot; no manifest/scope change required. Gateway restart is still required for the live adapter/config change to take effect.

@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins platform/slack Slack app adapter P3 Low — cosmetic, nice to have labels Jul 2, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Slack cleanup implementation. Current main confirms the premise: gateway/run.py:17505-17511 disables cleanup_progress when an adapter inherits the no-op BasePlatformAdapter.delete_message implementation (gateway/platforms/base.py:3005-3024), and Slack has no override. The shared path already tracks successful progress-message IDs (gateway/run.py:17899-17915) and deletes them after final delivery (gateway/run.py:20371-20413).

The proposed Slack call follows the existing workspace-aware client resolution in plugins/platforms/slack/adapter.py:1379-1386; the added direct adapter tests cover success, workspace selection, disconnection, exceptions, and ok: false responses.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 15, 2026
teknium1 added a commit that referenced this pull request Jul 23, 2026
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as
  'Minseo-Choi' — trac3r00's display name, same account)
- 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267)
- hello@jeromeiveson.com -> Trantor-develops (#57196)
- boumagent@gmail.com -> patp (#18859)
- dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
teknium1 added a commit that referenced this pull request Jul 23, 2026
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as
  'Minseo-Choi' — trac3r00's display name, same account)
- 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267)
- hello@jeromeiveson.com -> Trantor-develops (#57196)
- boumagent@gmail.com -> patp (#18859)
- dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
teknium1 added a commit that referenced this pull request Jul 23, 2026
- rt.cms012@gmail.com -> trac3r00 (#68378; commit authored as
  'Minseo-Choi' — trac3r00's display name, same account)
- 15167896+2001Y@users.noreply.github.com -> 2001Y (#64267)
- hello@jeromeiveson.com -> Trantor-develops (#57196)
- boumagent@gmail.com -> patp (#18859)
- dorukardahan@hotmail.com -> dorukardahan (#17184) was already mapped.
@teknium1

Copy link
Copy Markdown
Contributor

Merged via #70189 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your stale-progress deletion was cherry-picked.

Thanks for the contribution!

@teknium1 teknium1 closed this Jul 23, 2026
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
- rt.cms012@gmail.com -> trac3r00 (NousResearch#68378; commit authored as
  'Minseo-Choi' — trac3r00's display name, same account)
- 15167896+2001Y@users.noreply.github.com -> 2001Y (NousResearch#64267)
- hello@jeromeiveson.com -> Trantor-develops (NousResearch#57196)
- boumagent@gmail.com -> patp (NousResearch#18859)
- dorukardahan@hotmail.com -> dorukardahan (NousResearch#17184) was already mapped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have platform/slack Slack app adapter sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants