Skip to content

fix(stt): pass language to groq transcription - #57173

Closed
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-groq-stt-language
Closed

fix(stt): pass language to groq transcription#57173
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-groq-stt-language

Conversation

@tianma-if

Copy link
Copy Markdown
Contributor

Summary

  • pass language to Groq Whisper transcription requests when configured
  • prefer stt.groq.language, falling back to stt.local.language and the existing local STT language env
  • add regression coverage for Groq-specific language and local fallback behavior

Fixes #55551

Tests

  • .venv/bin/python -m pytest tests/tools/test_transcription_tools.py -q -k "TranscribeGroq or groq_language"
  • .venv/bin/python -m ruff check tools/transcription_tools.py tests/tools/test_transcription_tools.py
  • .venv/bin/python -m pytest tests/tools/test_transcription_tools.py -q
  • scripts/run_tests.sh tests/tools/test_transcription_tools.py -q

@alt-glitch alt-glitch added type/bug Something isn't working tool/tts Text-to-speech and transcription comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jul 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #55608 — same Groq STT language fix in _transcribe_groq (tools/transcription_tools.py), reading stt.groq.language > stt.local.language > the local STT env. #55608 is the earliest still-open code-only variant (canonical); #55713 was already marked a duplicate of it. Related: #55551 (the bug this fixes) and #23161 (an earlier, broader feat PR that also adds docs + a config example). Maintainer picks between the minimal code-only fix and #23161's broader version.

@tianma-if

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #55608 per triage; the earlier PR covers the same Groq STT language config fix. Thanks.

@tianma-if tianma-if closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists tool/tts Text-to-speech and transcription type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Groq STT missing language parameter — poor non-English transcription

2 participants