Skip to content

fix(dashboard): keep password auth on login form - #57021

Closed
jeeves-assistant wants to merge 1 commit into
NousResearch:mainfrom
jeeves-assistant:fix/dashboard-password-login-500
Closed

jeeves-assistant wants to merge 1 commit into
NousResearch:mainfrom
jeeves-assistant:fix/dashboard-password-login-500

Conversation

@jeeves-assistant

Copy link
Copy Markdown
Contributor

Summary

  • Prevent password-only dashboard auth providers from being auto-routed through the OAuth /auth/login flow.
  • Make direct /auth/login?provider=<password-provider> requests redirect back to /login instead of surfacing NotImplementedError as a 500.
  • Adds regressions for both the unauthenticated HTML auto-SSO path and direct login URL path.

Test plan

  • PYTHONPATH=. python -m pytest -q -o 'addopts=' tests/hermes_cli/test_dashboard_auth_password_login.py

@jeeves-assistant

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate. After opening it, I found several existing open PRs for the same dashboard basic/password-auth 500 bug (for example #56666, #56886, #56627, #56306, #56639, #55988, #55133, #54887). Current origin/main still reproduces the issue, so the bug is real, but this PR should not be the artifact of record.

@jeeves-assistant

Copy link
Copy Markdown
Contributor Author

Duplicate of existing dashboard basic/password-auth 500 PRs; closing to avoid adding another competing artifact.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/dashboard Web dashboard / control panel UI (dashboard/, landing) area/auth Authentication, OAuth, credential pools labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/dashboard Web dashboard / control panel UI (dashboard/, landing) P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants