feat(desktop): add live tasks sidebar view - #57004
Conversation
|
Follow-up fix pushed for the review findings. What changed:
Re-verified:
|
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the Live Tasks view and for the follow-up identity normalization. The feature is not already present on current main: apps/desktop/src/app/routes.ts:10-53 provides /agents but no /tasks route.
Problems
apps/desktop/src/app/tasks/index.tsx:205-209aggregates every key in the runtime todo/subagent stores. Currentapps/desktop/src/store/gateway-switch.ts:39-55clears session lists and foreground state on a soft gateway switch, but does not clear those runtime stores or the new mapping introduced inapps/desktop/src/store/session.ts:231. A previous gateway's live rows can therefore be rendered after re-home.- The PR adds the aggregation and mapping without tests; no changed PR file is a test/spec file. Please cover identity normalization and gateway-switch isolation.
Suggested changes
- Reset or scope the mapping plus todo/subagent live state at the same gateway/profile boundary used by
wipeSessionListsForGatewaySwitch(). - Add focused aggregation tests for mapped and unmapped runtime ids, plus the reset path.
Automated hermes-sweeper review.
|
|
||
| const storedIdByRuntimeSessionId = new Map(Object.entries(runtimeIdByStoredSessionId).map(([storedId, runtimeId]) => [runtimeId, storedId])) | ||
|
|
||
| const sessionIds = new Set<string>([ |
There was a problem hiding this comment.
This aggregates every runtime todo/subagent entry, but the soft gateway reset in store/gateway-switch.ts currently clears neither those stores nor the new stored→runtime mapping. Please scope or clear all three at the re-home boundary so a task from the prior gateway/profile cannot appear here.
989d808 to
56c3957
Compare
|
Implemented the requested follow-up and force-updated this PR onto current Key changes:
Regression coverage now includes mapped and unmapped runtime IDs, runtime-only busy/attention state, overlapping runtimes, lineage continuations, stale async completion after reset, cache cleanup, gateway-switch cleanup, and split-pane routing. Fresh verification on the updated branch:
Ready for re-review. |
56c3957 to
1768be7
Compare
|
Resolved the two reported conflicts by rebasing onto current upstream
Fresh post-rebase verification:
GitHub now reports the PR as mergeable ( |
Summary
/tasksroute into the desktop router and lazy-load the new pageTesting