fix(webhook): remove unused payload from retained delivery state (#2861 salvage) - #56945
Merged
Conversation
alt-glitch
added
type/perf
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retained webhook delivery state no longer holds the full request payload —
_delivery_infoentries kept up to ~1MB of dead weight per delivery for the 1-hour idempotency TTL, and no consumer ever read it (all readers access onlydeliver/deliver_extra).Salvage of #2861 by @VolodymyrBg (stale branch, cherry-picked onto current main with authorship preserved).
Changes
gateway/platforms/webhook.py: drop"payload": payloadfrom the retained agent-modedeliver_config(the request-scoped deliver-only dict is untouched)tests/gateway/test_webhook_adapter.py: remove the matching fixture keyscripts/release.py: AUTHOR_MAP entry for @VolodymyrBgValidation
Infographic
Nous Research