fix: replace assert with proper runtime validation guards (7 files) - #56866
Open
AlexFucuson9 wants to merge 1 commit into
Open
AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Assert statements are stripped when Python runs with -O flag, leaving None checks silently skipped and causing AttributeError or TypeError at runtime. Replace with explicit if/raise patterns that work in all Python optimization levels. Files fixed: - agent/transports/codex_app_server_session.py: client/thread_id guard - gateway/platforms/api_server.py: remove redundant assert after assignment - gateway/platforms/bluebubbles.py: HTTP client initialization check - gateway/platforms/weixin.py: poll/send session and token guards - gateway/relay/ws_transport.py: WebSocket connection guard - hermes_cli/main.py: subprocess stdout guard - hermes_cli/mcp_picker.py: catalog entry guard
alt-glitch
added
type/refactor
This was referenced Jul 10, 2026
Collaborator
|
Thanks for the focused runtime-validation cleanup. The central premise holds on current main, and the patch applies cleanly there. Problems
Suggested changes
Automated hermes-sweeper review. |
teknium1
added
sweeper:risk-session-state
3 tasks
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
assertstatements with explicitif/raiseguards across 7 files. Asserts are stripped in-Omode.Files