Skip to content

fix: serialize Pydantic AnyUrl fields when persisting MCP OAuth state #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amanuel2 wants to merge 1 commit into from
Closed

fix: serialize Pydantic AnyUrl fields when persisting MCP OAuth state #5677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/mcp_oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ async def get_tokens(self) -> "OAuthToken | None":
return None

async def set_tokens(self, tokens: "OAuthToken") -> None:
_write_json(self._tokens_path(), tokens.model_dump(exclude_none=True))
_write_json(self._tokens_path(), tokens.model_dump(mode="json", exclude_none=True))
logger.debug("OAuth tokens saved for %s", self._server_name)

# -- client info -------------------------------------------------------
Expand All @@ -219,7 +219,7 @@ async def get_client_info(self) -> "OAuthClientInformationFull | None":
return None

async def set_client_info(self, client_info: "OAuthClientInformationFull") -> None:
_write_json(self._client_info_path(), client_info.model_dump(exclude_none=True))
_write_json(self._client_info_path(), client_info.model_dump(mode="json", exclude_none=True))
logger.debug("OAuth client info saved for %s", self._server_name)

# -- cleanup -----------------------------------------------------------
Expand Down Expand Up @@ -462,7 +462,7 @@ def build_oauth_auth(
info_dict["scope"] = scope

client_info = OAuthClientInformationFull.model_validate(info_dict)
_write_json(storage._client_info_path(), client_info.model_dump(exclude_none=True))
_write_json(storage._client_info_path(), client_info.model_dump(mode="json", exclude_none=True))
logger.debug("Pre-registered client_id=%s for '%s'", client_id, server_name)

# --- Base URL for discovery ---
Expand Down