Skip to content

fix(toolsets): restore terminal toolset on api_server and acp composites (#56732) - #56735

Closed
HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/hermes-api-acp-terminal-toolset-56732
Closed

HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/hermes-api-acp-terminal-toolset-56732

Conversation

@HexLab98

@HexLab98 HexLab98 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • scripts/run_tests.sh tests/gateway/test_api_server_toolset.py tests/toolsets/test_composite_terminal_parity.py -q

Fixes #56732

@HexLab98
HexLab98 force-pushed the fix/hermes-api-acp-terminal-toolset-56732 branch from a517170 to 4ee543b Compare July 2, 2026 01:48
@alt-glitch alt-glitch added type/bug Something isn't working comp/tools Tool registry, model_tools, toolsets comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists labels Jul 2, 2026
HexLab98 added 2 commits July 2, 2026 09:06
Add read_terminal and close_terminal to the hand-written composite lists so
the terminal toolset passes _get_platform_tools subset inference instead of
being dropped entirely on api_server sessions (NousResearch#56732).
Assert hermes-acp/hermes-api-server include every registry-merged terminal
tool and that api_server platform config enables the terminal toolset.
@kshitijk4poor

Copy link
Copy Markdown
Contributor

Thanks for this — your fix and regression tests were correct, and you covered both composites plus added the subset-parity test. We ended up merging #56887 (salvage of #56480 by @designnotdrum), which fixes the same bug (#56732) at the reverse-map layer in _get_platform_tools() via a new include_registry=False static-membership comparison, rather than adding the two tools to each composite's hand-written list. The root-cause approach means the bug class can't recur the next time a tool is registered into terminal/delegation/etc., so no composite needs per-tool maintenance.

Your symptom-level fix was sound and would have resolved the immediate breakage — closing only because the layer fix supersedes it. Credited in the salvage PR body. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hermes-api-server / hermes-acp lose the entire 'terminal' toolset (silent subset-check failure vs. read_terminal/close_terminal)

3 participants