Conversation
a517170 to
4ee543b
Compare
Add read_terminal and close_terminal to the hand-written composite lists so the terminal toolset passes _get_platform_tools subset inference instead of being dropped entirely on api_server sessions (NousResearch#56732).
Assert hermes-acp/hermes-api-server include every registry-merged terminal tool and that api_server platform config enables the terminal toolset.
269466f to
a0f8826
Compare
|
Thanks for this — your fix and regression tests were correct, and you covered both composites plus added the subset-parity test. We ended up merging #56887 (salvage of #56480 by @designnotdrum), which fixes the same bug (#56732) at the reverse-map layer in Your symptom-level fix was sound and would have resolved the immediate breakage — closing only because the layer fix supersedes it. Credited in the salvage PR body. Thanks for the contribution! |
Summary
read_terminalandclose_terminaltohermes-acpandhermes-api-servercomposite tool lists intoolsets.pyterminaltoolset onapi_serverwhen_get_platform_tools()subset-inference compares against registry-mergedterminaltools (hermes-api-server / hermes-acp lose the entire 'terminal' toolset (silent subset-check failure vs. read_terminal/close_terminal) #56732)Test plan
scripts/run_tests.sh tests/gateway/test_api_server_toolset.py tests/toolsets/test_composite_terminal_parity.py -qFixes #56732