Skip to content

fix: pass request_overrides to background review and curator agents - #56653

Closed
TurgutKural wants to merge 2 commits into
NousResearch:mainfrom
TurgutKural:fix/background-review-missing-request-overrides
Closed

TurgutKural wants to merge 2 commits into
NousResearch:mainfrom
TurgutKural:fix/background-review-missing-request-overrides

Conversation

@TurgutKural

Copy link
Copy Markdown
Contributor

Bug

Background review and curator agents were not inheriting request_overrides from the parent agent or the resolved runtime provider. This caused provider-specific extra_body fields (like store: false for custom providers) to be missing from their LLM API calls.

Reproduction: Configure a custom provider with extra_body: store: false (e.g. pioneer provider). Regular chat completions send store: false correctly, but background review (skill/memory updates) and curator calls do not — the provider stores these requests when it shouldn't.

Fix

  • agent/background_review.py: The background review agent now inherits request_overrides from the parent agent via getattr(agent, "request_overrides", None).
  • agent/curator.py: The curator agent now extracts request_overrides from the resolved runtime provider (_rp.get("request_overrides")), matching the behavior of the main agent initialization path.

Root Cause

Both agent creation sites (background_review.py:648 and curator.py:1878) called AIAgent(...) without passing request_overrides. Since init_agent defaults request_overrides to {}, the provider's extra_body config was silently dropped for these auxiliary LLM calls.

Testing

  • Both files pass py_compile syntax check
  • The fix is minimal (4 lines added) and follows the existing pattern used in cli_commands_mixin.py which already passes request_overrides to its background agent

Background review and curator agents were not inheriting request_overrides
from the parent agent or the resolved runtime provider. This caused
provider-specific extra_body fields (like `store: false` for custom
providers) to be missing from their LLM API calls.

The background review agent (skill/memory updates) now inherits
request_overrides from the parent agent. The curator agent now extracts
request_overrides from the resolved runtime provider, matching the
behavior of the main agent initialization path.

Fixes the bug where custom providers with extra_body config (e.g.
`store: false`) were not applied to auxiliary LLM calls.
@alt-glitch alt-glitch added type/bug Something isn't working comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists labels Jul 1, 2026
@TurgutKural
TurgutKural deleted the fix/background-review-missing-request-overrides branch July 11, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants