feat(i18n): add 11 new languages — Korean, German, Spanish, French, Portuguese-BR, Arabic, Hindi, Thai, Vietnamese, Italian, Russian - #56220
Closed
iaendi wants to merge 1 commit into
Closed
Conversation
Converts our existing JSON locale files to upstream's defineLocale() TypeScript format. New languages (11): - Korean (ko), German (de), Spanish (es), French (fr) - Portuguese-Brazil (pt-br), Arabic (ar), Hindi (hi) - Thai (th), Vietnamese (vi), Italian (it), Russian (ru) Updates: - types.ts: extend Locale type union (4 → 15 locales) - catalog.ts: import and include all 11 new locales - languages.ts: add LOCALE_OPTIONS, LOCALE_ALIASES for all new locales Each locale uses defineLocale() for automatic English fallback. Approximately 850 translation keys per locale. [skip ci]
alt-glitch
added
type/feature
Author
|
This PR supersedes the earlier #38846 (now closed). Translation content from the 15-language JSON catalog has been converted to the upstream |
Author
|
Closing — switching to hybrid JSON+TS approach that keeps JSON as canonical translation source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 11 new Desktop UI locales to the i18n framework that landed in #38241, expanding language support from 4 to 15.
Each locale uses
defineLocale()with English fallback for any missing keys. All translations have been carried over from our earlier 15-language JSON catalog (the one in PR #38846) and converted to the upstream TypeScript format.New locales
Changes
apps/desktop/src/i18n/types.ts: ExtendLocaletype union (4 → 15)apps/desktop/src/i18n/catalog.ts: Import and register all 11 new localesapps/desktop/src/i18n/languages.ts: AddLOCALE_OPTIONSentries,LOCALE_META, andLOCALE_ALIASESfor all new localesapps/desktop/src/i18n/{ko,de,es,fr,pt-br,ar,hi,th,vi,it,ru}.ts: Full translation catalogs usingdefineLocale()Notes
LOCALE_META(endonym shown in picker), not translation keysCloses the Russian Desktop locale gap noted in #40347.
Related: #38846 (superseded omnibus PR)