feat(gateway): Enable Slack thread replies without explicit @mentions - #5579
Closed
jarvisxyz wants to merge 1 commit into
Closed
feat(gateway): Enable Slack thread replies without explicit @mentions#5579jarvisxyz wants to merge 1 commit into
jarvisxyz wants to merge 1 commit into
Conversation
When a user replies in a Slack thread where the bot has an active conversation session, the bot now processes the message even without an explicit @mention. This improves UX for ongoing threaded discussions. Changes: - Added set_session_store() to BasePlatformAdapter for adapters to check active sessions - Modified SlackAdapter to detect thread replies and check if a session exists for that thread before requiring @mentions - Updated GatewayRunner to inject the session store into adapters - Added comprehensive tests for the new behavior Fixes: Thread replies without @jarvis are now processed if there is an active session, matching user expectations for conversation flow
Merged
3 tasks
This was referenced Apr 6, 2026
Contributor
|
Merged via PR #5733. Your commit was cherry-picked with authorship preserved. Thanks @jarvisxyz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PR: jarvisxyz#1 (testing/verification)
Changes:
When a user replies in a Slack thread where the bot has an active conversation session, the bot now processes the message even without an explicit @mention. This improves UX for ongoing threaded discussions.
set_session_store()to BasePlatformAdapter for adapters to check active sessionsTesting:
Tests included in
tests/gateway/test_slack.pycovering:Related: This addresses the common user expectation that once a thread conversation is started, replies within that thread should not require repeated @mentions.