Skip to content

fix(model-picker): handle list-of-dict models: in provider config #55770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iambuddy829-del wants to merge 1 commit into from
Closed

fix(model-picker): handle list-of-dict models: in provider config #55770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions hermes_cli/model_switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1958,8 +1958,14 @@ def _has_aws_sdk_creds_for_listing(slug: str) -> bool:
models_list.append(m)
elif isinstance(cfg_models, list):
for m in cfg_models:
if m and m not in models_list:
models_list.append(m)
# List entries are normally plain id strings, but hand-edited
# configs sometimes use {id|model|name: ..., label: ...} dicts.
# Extract the id so models_list stays a list[str]: every
# downstream consumer (inventory dedup, capabilities, pricing)
# assumes string ids and calls .lower() / uses them as keys.
mid = (m.get("id") or m.get("model") or m.get("name") or "") if isinstance(m, dict) else m
if mid and mid not in models_list:
models_list.append(mid)

# Official OpenAI API rows in providers: often have base_url but no
# explicit models: dict — avoid a misleading zero count in /model.
Expand Down