fix(delegate): share credential pools with subagents - #5576
Closed
MestreY0d4-Uninter wants to merge 1 commit into
Closed
fix(delegate): share credential pools with subagents#5576MestreY0d4-Uninter wants to merge 1 commit into
MestreY0d4-Uninter wants to merge 1 commit into
Conversation
This was referenced Apr 6, 2026
Contributor
|
Closing — fully subsumed by #5580 (which includes credential sharing + leasing). Thanks @MestreY0d4-Uninter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes delegated child agents participate in credential-pool rotation instead of inheriting a single fixed credential from the parent.
Today, even when a parent agent has access to a healthy credential pool, a subagent can end up knowing only one effective credential. If that credential hits a rate limit or quota wall, the child stalls even though the pool still has other usable entries.
This patch keeps the change intentionally small:
What changed
_resolve_child_credential_pool()intools/delegate_tool.py_build_child_agent()now assigns a credential pool to the child when availableWhy
This is the smallest useful extraction from the larger credential-pool hardening branch.
It improves real subagent resilience without pulling in the more invasive pieces yet:
Validation
Automated
/home/ubuntu/.hermes/hermes-agent/venv/bin/python -m py_compile tools/delegate_tool.py tests/tools/test_delegate.py/home/ubuntu/.hermes/hermes-agent/venv/bin/python -m pytest -q -o addopts='' tests/tools/test_delegate.py -k 'ChildCredentialPoolResolution or DelegationProviderIntegration'13 passed, 44 deselectedAdditional focused validation:
/home/ubuntu/.hermes/hermes-agent/venv/bin/python -m pytest -q -o addopts='' tests/tools/test_delegate.py57 passedRelated context
Scope notes
This PR only makes child agents see and use credential pools.
It does not yet add: