Skip to content

fix(windows): add CREATE_BREAKAWAY_FROM_JOB to windows_hide_flags() #55753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ms-alan wants to merge 1 commit into from
+6 −1
Closed

fix(windows): add CREATE_BREAKAWAY_FROM_JOB to windows_hide_flags() #55753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hermes_cli/_subprocess_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,12 @@ def windows_hide_flags() -> int:
"""
if not IS_WINDOWS:
return 0
return _CREATE_NO_WINDOW
# _CREATE_BREAKAWAY_FROM_JOB is needed even for short-lived synchronous
# children: Electron/Tauri desktop apps wrap their subprocesses in job
# objects, and without breakaway a child started with capture_output=True
# can be killed when the parent Electron/Tauri process exits — even though
# DETACHED_PROCESS is not set and stdio is still connected.
return _CREATE_NO_WINDOW | _CREATE_BREAKAWAY_FROM_JOB

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CREATE_BREAKAWAY_FROM_JOB can make CreateProcess fail when the parent job disallows breakaway; current main documents this at hermes_cli/_subprocess_compat.py:138-144. Because this helper is used by synchronous callers without an OSError retry (for example tools/environments/base.py:145-153), please avoid applying this bit globally unless the fallback is designed and covered.



def windows_detach_popen_kwargs() -> dict:
Expand Down
Loading