docs(config): align max_turns example with actual default (90) - #55673
Closed
waroffchange wants to merge 1 commit into
Closed
docs(config): align max_turns example with actual default (90)#55673waroffchange wants to merge 1 commit into
waroffchange wants to merge 1 commit into
Conversation
Contributor
|
Thanks for correcting this stale example. Current main still has Automated hermes-sweeper review. |
teknium1
added a commit
that referenced
this pull request
Jul 26, 2026
Follow-up on top of @waroffchange's alignment fix (#55673): the real default changed from 90 to 500 in #72176, so bring the example value and comment up to the current default.
Contributor
|
Thanks @waroffchange — you were right about the example/default drift. Your commit was cherry-picked (authorship preserved) into #72182 and merged; the only adjustment was updating the target value from 90 to 500, since #72176 raised the actual default after your PR was opened. Closing in favor of #72182. |
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
Follow-up on top of @waroffchange's alignment fix (NousResearch#55673): the real default changed from 90 to 500 in NousResearch#72176, so bring the example value and comment up to the current default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example config (
cli-config.yaml.example) shippedmax_turns: 60, but the actual default used across the codebase is90:hermes_cli/config.py?DEFAULT_CONFIG["agent"]["max_turns"] = 90hermes_cli/_parser.py?--max-turnshelp text states "default: 90"AGENTS.md?AIAgent.__init__(max_iterations: int = 90)This aligns the example file with the real default and adds the
(default: 90)annotation, matching the style already used for other keys in the same file (e.g.compression:).Validation
Related
Related to the default-value work done in #4020 / #4031 (example file was missed)