Skip to content

docs(config): align max_turns example with actual default (90) - #55673

Closed
waroffchange wants to merge 1 commit into
NousResearch:mainfrom
waroffchange:docs/fix-cli-config-max-turns-default
Closed

docs(config): align max_turns example with actual default (90)#55673
waroffchange wants to merge 1 commit into
NousResearch:mainfrom
waroffchange:docs/fix-cli-config-max-turns-default

Conversation

@waroffchange

Copy link
Copy Markdown
Contributor

Summary

The example config (cli-config.yaml.example) shipped max_turns: 60, but the actual default used across the codebase is 90:

  • hermes_cli/config.py ? DEFAULT_CONFIG["agent"]["max_turns"] = 90
  • hermes_cli/_parser.py ? --max-turns help text states "default: 90"
  • AGENTS.md ? AIAgent.__init__(max_iterations: int = 90)

This aligns the example file with the real default and adds the (default: 90) annotation, matching the style already used for other keys in the same file (e.g. compression:).

Validation

Related

Related to the default-value work done in #4020 / #4031 (example file was missed)

@alt-glitch alt-glitch added type/docs Documentation improvements area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have labels Jun 30, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for correcting this stale example. Current main still has max_turns: 60 in cli-config.yaml.example:684, while the actual default is 90 in hermes_cli/config.py:991 and the CLI help states the same at hermes_cli/_parser.py:385. The PR’s focused documentation change matches current behavior.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 15, 2026
teknium1 added a commit that referenced this pull request Jul 26, 2026
Follow-up on top of @waroffchange's alignment fix (#55673): the real
default changed from 90 to 500 in #72176, so bring the example value
and comment up to the current default.
@teknium1

Copy link
Copy Markdown
Contributor

Thanks @waroffchange — you were right about the example/default drift. Your commit was cherry-picked (authorship preserved) into #72182 and merged; the only adjustment was updating the target value from 90 to 500, since #72176 raised the actual default after your PR was opened. Closing in favor of #72182.

@teknium1 teknium1 closed this Jul 26, 2026
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
Follow-up on top of @waroffchange's alignment fix (NousResearch#55673): the real
default changed from 90 to 500 in NousResearch#72176, so bring the example value
and comment up to the current default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants