Skip to content

fix(agent): #5544 strictly enforce toolset filters for memory provide… #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MustafaKara7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(agent): #5544 strictly enforce toolset filters for memory provide… #5552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,14 +1112,21 @@ def __init__(
self._memory_manager = None

# Inject memory provider tool schemas into the tool surface
if self._memory_manager and self.tools is not None:
# Respect both enabled and disabled toolsets configurations

@teknium1 teknium1 Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not carry this direct membership check into the current helper unchanged: current main supports composite toolsets through memory_provider_tools_enabled() (agent/memory_manager.py:91-94), and tests/agent/test_memory_provider.py:1363-1368 verifies that hermes-acp exposes provider memory tools. Preserve that resolver and add the disabled-toolset check separately.

_memory_allowed = True
if self.enabled_toolsets is not None and "memory" not in self.enabled_toolsets:
_memory_allowed = False
if self.disabled_toolsets is not None and "memory" in self.disabled_toolsets:
_memory_allowed = False

if self._memory_manager and self.tools is not None and _memory_allowed:
for _schema in self._memory_manager.get_all_tool_schemas():
_wrapped = {"type": "function", "function": _schema}
self.tools.append(_wrapped)
_tname = _schema.get("name", "")
if _tname:
self.valid_tool_names.add(_tname)

# Skills config: nudge interval for skill creation reminders
self._skill_nudge_interval = 10
try:
Expand Down