refactor(desktop): colocate hook/component families into scoped folders - #55493
Merged
Merged
Conversation
Single-scoped helpers/sub-files were sitting flat in shared/grab-bag dirs.
Fold each family into its own folder (index = the export, dir resolution keeps
public import paths intact), dropping the now-redundant filename prefix:
- session/hooks/use-prompt-actions.ts (+ -utils, + tests)
-> use-prompt-actions/{index,utils}.ts (+ tests)
- components/assistant-ui/thread* + assistant/system/user message renderers
-> assistant-ui/thread/{index,content,status,message-parts,timestamp,types,
list,timeline,timeline-data,assistant-message,system-message,user-message,
user-edit-composer,user-message-text} (+ tests)
- components/assistant-ui/tool-fallback(+model)/tool-approval
-> assistant-ui/tool/{fallback,fallback-model,approval} (+ tests)
Pure move + import rewrites; no behaviour change. App-wide shared primitives
(markdown-text, directive-text, tooltip-icon-button, clarify-tool, ansi-text,
message-render-boundary) stay flat. desktop-controller intentionally left in
app/ (route root; foldering would churn ~80 relative imports for no gain).
4 tasks
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ok-folders refactor(desktop): colocate hook/component families into scoped folders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the repo's own feature-folder convention to the few single-scoped families that were still sitting flat in shared/grab-bag dirs. Each family folds into its own folder with
indexas the export — directory resolution keeps the public import path identical for external consumers — and the now-redundant filename prefix is dropped.Folded
session/hooks/use-prompt-actions.ts(+-utils, + tests) →use-prompt-actions/{index,utils}.ts(a-utilshelper was living in the sharedhooks/dir next to unrelated hooks).components/assistant-ui/thread render family →assistant-ui/thread/(index,content,status,message-parts,timestamp,types,list,timeline,timeline-data,assistant-message,system-message,user-message,user-edit-composer,user-message-text+ tests).components/assistant-ui/tool family →assistant-ui/tool/(fallback,fallback-model,approval+ tests).Deliberately left flat
assistant-ui/:markdown-text,directive-text,tooltip-icon-button,clarify-tool,ansi-text,message-render-boundary— not thread/tool-scoped.app/desktop-controller.tsx— a route root with ~80 relative imports; foldering would churn all of them for no real gain, andapp/is its correct home.lib/,store/,components/ui/— collections of independent modules, not families.Notes
git mv+ mechanical import-specifier rewrites;Threadetc. still import from@/components/assistant-ui/thread(resolves tothread/index).Test plan
npm run typecheck— 0 errorseslinton changed dirs — cleancontent/timestamp/timeline-data,tool/fallback-modelschema bits,use-prompt-actions/utils)<Thread>-render tests (block-direction,streaming,user-message-edit) and twotool/fallback-modelURL-ellipsis assertions fail identically on unmodifiedmainin this local env (jsdom lacksCSS.escape; CI provides it) — not introduced here.